M

unassociatedAttachmentLimit calculated incorrectly

  • Thread starter Thread starter mattrogowski
  • Start date Start date

Visitor Greeting

Welcome to NullWarehouse.com... We are currently seeking Mod's and Contributors. If you wish to apply for a Mod position then please click on Members dropdown arrow, then click on Staff App and fill it out completely and submit it. If you want to be a Contributor then start contributing and we will have our eye on you and take notice, something great could come of it.

  • We have redone the forum. If you notice any issues or errors please open a Support Ticket under the Members dropdown and let us know.
M

mattrogowski

Guest

Very minor issue but the unassociatedAttachmentLimit config value actually accepts 1 less than the limit. Easier to test if you set $config['unassociatedAttachmentLimit'] = 2;, you get the error after uploading 1 attachment instead of 2.

src/XF/Attachment/Manipulator.php:140:

$allowed = ($uploaded < $unassociatedLimit);

just needs to be:

$allowed = ($uploaded <= $unassociatedLimit);

Then it accepts 2 and rejects a 3rd.

Strangely the check above works...


Read more

Continue reading...
 
Similar content Most view View more
Back
Top Bottom