K

Extending NotifierService::notifyCreate is complicated

  • Thread starter Thread starter Kirby
  • Start date Start date

Visitor Greeting

Welcome to NullWarehouse.com... We are currently seeking Mod's and Contributors. If you wish to apply for a Mod position then please click on Members dropdown arrow, then click on Staff App and fill it out completely and submit it. If you want to be a Contributor then start contributing and we will have our eye on you and take notice, something great could come of it.

  • We have redone the forum. If you notice any issues or errors please open a Support Ticket under the Members dropdown and let us know.
K

Kirby

Guest

\XF\Service\Report\NotifierService::notifyCreate is currently kinda monolithic which makes it somewhat difficult to extend.

Could this be made more modular, eg. smth. like

PHP:
Code:
protected function getCreateNotificationEmailParams(User $user): array
{
    $report = $this->report;
    $comment = $this->comment;

    return [
        'receiver' => $user,
        'reporter' => $comment->User,
        'comment' => $comment,
        'report' => $report,
        'message' =>...

Read more

Continue reading...
 
Similar content Most view View more
Back
Top Bottom