X

Approval queue will trigger unexpected rebuilds when using filters

  • Thread starter Thread starter Xon
  • Start date Start date

Visitor Greeting

Welcome to NullWarehouse.com... We are currently seeking Mod's and Contributors. If you wish to apply for a Mod position then please click on Members dropdown arrow, then click on Staff App and fill it out completely and submit it. If you want to be a Contributor then start contributing and we will have our eye on you and take notice, something great could come of it.

  • We have redone the forum. If you notice any issues or errors please open a Support Ticket under the Members dropdown and let us know.
X

Xon

Guest

PHP:

Code:
$filters = $this->getQueueFilterInput();
$this->applyQueueFilters($unapprovedFinder, $filters);
...

if ($unapprovedItems->count() != $this->app->unapprovedCounts['total'])
{
    $approvalQueueRepo->rebuildUnapprovedCounts();
}

rebuildUnapprovedCounts will be unexpectedly called because unapprovedItems can be a limited unset of the the full list. Checking conditions on the finder isn't enough as there might be a required joins which are excluding things via a 3rd party...

Read more

Continue reading...
 
Back
Top Bottom